Skip to content

Remove webui#345

Merged
JingMatrix merged 5 commits intoJingMatrix:masterfrom
Qing0731:master
Jul 21, 2025
Merged

Remove webui#345
JingMatrix merged 5 commits intoJingMatrix:masterfrom
Qing0731:master

Conversation

@Qing0731
Copy link
Copy Markdown
Contributor

@Qing0731 Qing0731 commented Jul 13, 2025

The effects of webui and action are the same, so there is no need for both to exist simultaneously. Therefore, webui should be removed

@JingMatrix
Copy link
Copy Markdown
Owner

It is fine to co-exist for this monent.
There is no special attention needed to maintain it.

@Keeperorowner
Copy link
Copy Markdown

It is unnecessary to have two buttons with exactly the same function in the lsposed module of the root manager. One of them should be removed

@rifsxd
Copy link
Copy Markdown

rifsxd commented Jul 14, 2025

A webui is just useless to call the same thing that action calls, plus all root manager has actions and magisk alone doesn't have webui so it's just unnecessary to keep webroot

@frknkrc44
Copy link
Copy Markdown
Contributor

frknkrc44 commented Jul 15, 2025

You also need to remove the "generateWebRoot" Gradle action.

https://github.com/JingMatrix/LSPosed/blob/f081aa38990cbb9ec3d5a2787a5ec268fd9eed9e/magisk-loader/build.gradle.kts#L115

@frknkrc44
Copy link
Copy Markdown
Contributor

frknkrc44 commented Jul 15, 2025

You forgot to remove its caller, https://github.com/JingMatrix/LSPosed/blob/f081aa38990cbb9ec3d5a2787a5ec268fd9eed9e/magisk-loader/build.gradle.kts#L175

@JingMatrix
Copy link
Copy Markdown
Owner

I will merge this when you finish cleaning the gradle configurations.

@Keeperorowner
Copy link
Copy Markdown

@JingMatrix

@JingMatrix
Copy link
Copy Markdown
Owner

Be patient, @Keeperorowner, this is not a urgent pull-request, we can still wait for some more comments (or not).

@frknkrc44
Copy link
Copy Markdown
Contributor

This PR looks good to me.

@JingMatrix
Copy link
Copy Markdown
Owner

Please refer to f8409ad, and remove pnpm dependencies in GitHub Actions;

@JingMatrix JingMatrix merged commit 108149b into JingMatrix:master Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants